[Webkit-unassigned] [Bug 88196] REGRESSION (r96393): In some cases, generated content is never shown

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 05:35:24 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88196





--- Comment #7 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-06-20 05:35:23 PST ---
The problem here is that an attribute selector appended by a pseudo-element does not return any matched rules for the call: (matchesRuleSet(m_uncommonAttributeRuleSet.get())) in locateSharedStyle().

This is because of the way pseudo-elements are handled in SelectorChecker::checkOneSelector(). For a pseudo-element selector we check for the condition (!context.elementStyle && m_mode == ResolvingStyle) and since currently the SelectorChecker mode is set to ResolvingStyle and since the current element's style is still not available we fail this check and (wrongly) return false from checkOneSelector().

Have thus introduced another enum value: SharingRules (not sure about the name though) for SelectorChecker's mode. Before making the locateSharedStyle() call we can set the SelectorChecker mode to SharingRules and then reset the same post the call.

Existing mode value "CollectingRules" although appropriate cannot be used in this scenario because we also don't want to set any value to dynamicPseudo for this flow.
if (pseudoId != NOPSEUDO)
    dynamicPseudo = pseudoId;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list