[Webkit-unassigned] [Bug 88268] [chromium] Expose rendering statistics to WebLayerTreeView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88268





--- Comment #22 from Nat Duca <nduca at chromium.org>  2012-06-19 22:45:07 PST ---
(From update of attachment 148477)
View in context: https://bugs.webkit.org/attachment.cgi?id=148477&action=review

LGTM, but verify the tests. Did you sort out whether there's a clean way to output WebRenderingStats into JS value objects?

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:-262
> -    m_frameNumber++;

I bet this breaks a few cclayertreehost tests. build and run webkit_unit_tests to verify.  you can probably fix the tests.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:327
> +    m_proxy->renderingStats(stats);

bikeshed in me still questions this method name. Should the method name explain that its filling in only impl-side fields on the stats structure? E.g. implSideRenderingStats()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.