[Webkit-unassigned] [Bug 88268] [chromium] Expose rendering statistics to WebLayerTreeView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88268





--- Comment #19 from Dave Tu <dtu at chromium.org>  2012-06-19 17:57:19 PST ---
(From update of attachment 147697)
View in context: https://bugs.webkit.org/attachment.cgi?id=147697&action=review

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:326
>> +    stats.numAnimationFrames = frameNumber();
> 
> How about renaming the vars here too, instead of having m_framenNumber, you have m_animationFrameNumber or something. And updating the impl side to have m_sourceAnimationFrameNumber. You should also update that when we call m_client->animate -- check both the single thread and ccthread proxy to understand when that happens. FrameNumber as measured now isn't 1:1 with calls to composite, which is where we currently bump frameNumber.

Done.

>> Source/WebKit/chromium/public/WebView.h:364
>> +    // Fills in a WebRenderingStats struct containing information about the state of the compositor.
> 
> There's a GPU section in the webview i think. Look for graphcisContext3D

Done.

>> Source/WebKit/chromium/src/WebViewImpl.cpp:1461
>> +    if (!m_layerTreeView.isNull())
> 
> You still need an assert_not_reached in software mode. This is the member variable m_isAcceleratedRenderignActive or something like that.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.