[Webkit-unassigned] [Bug 54531] [GTK] [Windows] Plugins fail to load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54531


Kalev Lember <kalevlember at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kalevlember at gmail.com




--- Comment #7 from Kalev Lember <kalevlember at gmail.com>  2012-06-19 14:39:04 PST ---
(In reply to comment #6)
> (From update of attachment 148389 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148389&action=review
> 
> Great work! It seems like we can remove the code duplication in GraphicsContext though.

Thanks!


> > Source/WebCore/GNUmakefile.am:979
> > +if TARGET_WIN32
> > +libWebCore_la_LIBADD = -lversion
> > +endif
> > +
> 
> Probably want to drop a little comment explaining why this is necessary.

Done.


> > Source/WebCore/GNUmakefile.list.am:4823
> > +	Source/WebCore/plugins/gtk/PluginPackageGtk.cpp \
> > +	Source/WebCore/plugins/gtk/PluginViewGtk.cpp \
> 
> This looks like it breaks non-X11, non Win32 builds. For instance, DirectFB. Granted plugins probably do not work there anyway.

Indeed. I've now moved this to TARGET_WIN32 else section, although I'm wondering if we should instead use PluginPackageNone.cpp and PluginViewNone.cpp on such platforms.


> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1134
> > +#if (PLATFORM(GTK) && OS(WINDOWS))
> > +static void setRGBABitmapAlpha(unsigned char* bytes, size_t length, unsigned char level)
> 
> Why not simply add the GraphicsContextWin.cpp and GraphicsContextCairoWin.cpp files to the source list instead of duplicating all this code here?

I'll give this a try. Is there any EWS bot for checking that the CairoWin port still builds?


> > Source/WebCore/plugins/win/PluginViewWin.cpp:113
> > +    if (GdkWindow *window = gtk_widget_get_window(client))
> 
> Asterisks go next to the variable name in WebKit.

Fixed.


> > Source/WebCore/plugins/win/PluginViewWin.cpp:114
> > +        return (HWND)GDK_WINDOW_HWND(window);
> 
> Are you sure you have to cast here? If you do, you should use a C++ style cast (static_cast).

Yeah, the cast is needed: confusingly enough, GDK_WINDOW_HWND() returns HGDIOBJ instead of a HWND.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.