[Webkit-unassigned] [Bug 89000] [CSS Regions] Fix the lifecycle for the flow objects and their renderers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89000





--- Comment #18 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-06-19 06:41:58 PST ---
(From update of attachment 148118)
View in context: https://bugs.webkit.org/attachment.cgi?id=148118&action=review

Just a quick style scan, but the code seems clean to my eye.

> Source/WebCore/ChangeLog:6
> +        This patch adds the concept of a NamedFlowCollection, owned by the document, that keeps track of

Reviewers say that the verbose description should reside AFTER the "Reviewed by" line (you may want to ask for another opinion, since I'm also used to the text immediately following the bug summary).

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28243
> +				SYMROOT = /Users/abucur/NonPerforce/WebKit/WebKitBuild/namedflow_lifecycle;

I believe this line is somewhat wrong...

> Source/WebCore/dom/Document.cpp:1129
> +    // It's possible to have pendiding styles not applied that affect the existing flows

Comments should end with a period (http://www.webkit.org/coding/coding-style.html#comments-sentences). This should be fixed in all comments you have added.

> LayoutTests/ChangeLog:6
> +        These tests expected that getFlowByName() to return a valid object even for the NULL flows. They've been modified to

stray "that" before "getFlowByName()"

> LayoutTests/fast/regions/webkit-named-flow-content-nodes.html:28
> +			

FYI: there's a lot of leading whitespace here

> LayoutTests/fast/regions/webkit-named-flow-content-nodes.html:29
> +			shouldBeNull('document.webkitGetFlowByName("flow")');

Is this out-of-order indentation intentional?

> LayoutTests/fast/regions/webkit-named-flow-content-nodes.html:120
> +			shouldBeNull('document.webkitGetFlowByName("flow2")');

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.