[Webkit-unassigned] [Bug 75824] check-webkit-style should warn about missing svn:mime-type for png files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75824





--- Comment #31 from Csaba Osztrogonac <ossy at webkit.org>  2012-06-18 22:50:54 PST ---
(In reply to comment #30)
> This check is really annoying because it doesn't solve the problem for me:
> 
> LayoutTests/platform/chromium-win/fast/multicol/progression-reverse-expected.png:0:  Set the svn:mime-type property (svn propset svn:mime-type image/png LayoutTests/platform/chromium-win/fast/multicol/progression-reverse-expected.png).  [image/png] [5]
> LayoutTests/platform/chromium-mac/fast/multicol/progression-reverse-expected.png:0:  Set the svn:mime-type property (svn propset svn:mime-type image/png LayoutTests/platform/chromium-mac/fast/multicol/progression-reverse-expected.png).  [image/png] [5]
> LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/progression-reverse-expected.png:0:  Set the svn:mime-type property (svn propset svn:mime-type image/png LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/progression-reverse-expected.png).  [image/png] [5]
> LayoutTests/platform/chromium-linux/fast/multicol/progression-reverse-expected.png:0:  Set the svn:mime-type property (svn propset svn:mime-type image/png LayoutTests/platform/chromium-linux/fast/multicol/progression-reverse-expected.png).  [image/png] [5]

check-webkit-style won't solve your problem, it only warns you if you do something wrong. We should set svn mimetype for all png files - https://lists.webkit.org/pipermail/webkit-dev/2012-March/019783.html , but you didn't. That's why check-webkit-style warned you and suggested what to do: svn propset svn:mime-type image/png LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/progression-reverse-expected.png )

But https://bugs.webkit.org/show_bug.cgi?id=75825 will do it automatically once the fix is landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.