[Webkit-unassigned] [Bug 89410] JSC needs to record line numbers for exception stack traces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89410


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148229|review?                     |review-
               Flag|                            |




--- Comment #4 from Geoffrey Garen <ggaren at apple.com>  2012-06-18 20:20:27 PST ---
(From update of attachment 148229)
View in context: https://bugs.webkit.org/attachment.cgi?id=148229&action=review

Approach looks good, but this patch could use some tweaks before landing.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1603
> +    , m_lineInfo()

"m_lineInfo(other.m_lineInfo)" would be better here, to avoid zero-initializing m_lineInfo just to overwrite it later.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1653
> +    , m_lineInfo()

WebKit style is to omit implicit initializers like this one.

> Source/JavaScriptCore/bytecode/CodeBlock.h:726
> +            return m_lineInfo.size() || (m_rareData

m_lineInfo.size() is always > 0 now, right? If so, I think you should just return true here, and we can remove this optimization in another patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.