[Webkit-unassigned] [Bug 89375] New: ConditionalMacros.h causes compiler errors for MSVC x64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89375

           Summary: ConditionalMacros.h causes compiler errors for MSVC
                    x64
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows 7
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: alex.christensen at flexsim.com


When compiling JavaScriptCore with MSVC for a x64 target, there are many errors caused by the lack of definitions from WebKitLibraries\win\include\ConditionalMacros.h.  Line 1054 of this file currently reads as follows:

    #elif defined(_M_IX86) /* Visual Studio with Intel x86 target */

Replacing it with the following causes many macros to be defined (perhaps not correctly), but it compiles.

    #elif defined(_M_IX86) || defined(_M_AMD64)  /* Visual Studio with Intel x86 or x64 target */

Should this be changed?  Is this the change that should be made?  It's not in the repository, so it can't be patched.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.