[Webkit-unassigned] [Bug 89250] [chromium] Browser Plugin/Pepper: Make mouse events to transform properly in WebPluginContainer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89250





--- Comment #3 from lazyboy at chromium.org  2012-06-18 13:20:11 PST ---
(From update of attachment 147912)
View in context: https://bugs.webkit.org/attachment.cgi?id=147912&action=review

>> Source/WebKit/chromium/src/WebInputEventConversion.cpp:355
>> +WebMouseEventBuilder::WebMouseEventBuilder(const Widget* widget, const RenderObject* renderer, const MouseEvent& event)
> 
> I suspect that using a RenderObject here is a layering violation and you need to do something different.

I tried avoiding renderer(), but couldn't since seems like only it has the transformation info (I tried calling other mapping function in element/widget {similar to absoluteToLocal one below}).
I'm also not sure RenderObject would be always nonNULL at the point when event arrives?

>> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:598
>> +    WebMouseEventBuilder webEvent(this, m_element->renderer(), *event);
> 
> As I understand how things work, the events should be transformed appropriately by the time they arrive in this object -- so you should look into why this code is not receiving appropriately transformed events.

This event handler gets called from WebCore, (HTMLPluginElement.defaultEventHandler), do you think it should be already transformed at that point?
I'm currently looking into HTMLIFrameElement's event handling code path and trying figure out where in the chain the events gets transformed, do you think HTMLPluginElement should follow the same pattern for transforming events?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.