[Webkit-unassigned] [Bug 88344] Fix FastMalloc.cpp compile error for MSVC in 64-bit
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 18 11:15:34 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=88344
--- Comment #32 from WebKit Review Bot <webkit.review.bot at gmail.com> 2012-06-18 11:15:33 PST ---
Attachment 148131 did not pass style-queue:
Source/WTF/wtf/FastMalloc.cpp:1293: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WTF/wtf/FastMalloc.cpp:970: Tab found; better to use spaces [whitespace/tab] [1]
Source/WTF/wtf/FastMalloc.cpp:1114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1118: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1120: The parameter name "N" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WTF/wtf/FastMalloc.cpp:1120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1123: The parameter name "N" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WTF/wtf/FastMalloc.cpp:1123: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1125: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1126: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1132: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1132: tc_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1159: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1160: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4]
Source/WTF/wtf/FastMalloc.cpp:1161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1164: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1164: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1165: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1165: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1166: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4]
Source/WTF/wtf/FastMalloc.cpp:1167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1169: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1174: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1175: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1177: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WTF/wtf/FastMalloc.cpp:1177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1180: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1181: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1185: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1186: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1191: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1192: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1193: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1195: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1197: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1198: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1198: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1199: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1201: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1204: locked_size_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1206: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1208: lock_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1210: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1211: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1211: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1211: Extra space between size_t and size_class_ [whitespace/declaration] [3]
Source/WTF/wtf/FastMalloc.cpp:1211: size_class_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1212: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1212: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1212: Extra space between Span and empty_ [whitespace/declaration] [3]
Source/WTF/wtf/FastMalloc.cpp:1212: empty_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1213: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1213: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1213: Extra space between Span and nonempty_ [whitespace/declaration] [3]
Source/WTF/wtf/FastMalloc.cpp:1213: nonempty_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1214: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1214: Extra space between size_t and counter_ [whitespace/declaration] [3]
Source/WTF/wtf/FastMalloc.cpp:1214: counter_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1216: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1219: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1219: tc_slots_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1221: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1223: used_slots_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1224: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1224: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1225: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1226: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1227: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1227: cache_size_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1233: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1233: pad_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1260: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WTF/wtf/FastMalloc.cpp:1279: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1290: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1291: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1293: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1293: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1293: kernel_supports_tls is incoFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Fa..." exit_code: 1
rrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1294: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1294: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1296: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1297: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1298: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1302: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1303: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1305: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1305: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WTF/wtf/FastMalloc.cpp:1308: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WTF/wtf/FastMalloc.cpp:1310: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1312: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WTF/wtf/FastMalloc.cpp:1313: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WTF/wtf/FastMalloc.cpp:1314: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1318: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1320: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1323: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1324: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1326: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1329: One space before end of line comments [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1330: One space before end of line comments [whitespace/comments] [5]
Total errors found: 147 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list