[Webkit-unassigned] [Bug 89362] New: [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 18 10:56:52 PDT 2012


           Summary: [garden-o-matic] Builder names without underscores
                    cause incorrect BuildSelector behavior
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zandobersek at gmail.com
                CC: abarth at webkit.org, simon.fraser at apple.com

Builder names without underscores cause the BuildSelector object to not store the containers in the proper way, displaying all the containers instead of just the one the selected tab is linked with.

An example of this is when viewing results for the Apple builders - the container id and hash that's used in the associated tab are just encoded as URI components (the result of the current platform's resultsDirectoryNameFromBuilderName method), which doesn't work. Chromium doesn't have such problems as the builders' results directories are already replacing whitespace, braces and dots with underscores.

JQuery documentation[1] suggests something similar.

I think it's safe to convert whitespace, braces and dots to underscores for every builder name in ui.results.BuilderSelector.init and use that to link the container with the associated tab.

[1] - http://docs.jquery.com/UI/Tabs#Ajax_mode

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list