[Webkit-unassigned] [Bug 67935] webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is missing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 18 07:18:11 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=67935





--- Comment #17 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-06-18 07:18:09 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=148090&action=review

> Tools/Scripts/webkitpy/common/checkout/changelog.py:358
> +            bug_url_number = len(re.findall(config_urls.bug_url_long, latest_entry, re.MULTILINE))
> +            bug_url_number += len(re.findall(config_urls.bug_url_short, latest_entry, re.MULTILINE))

Could we use a more descriptive name?

> Tools/Scripts/webkitpy/common/checkout/changelog.py:367
> +                if found_bug_url and bug_url_number == 1:
> +                    print "\n        Reviewed by %s." % (reviewer.encode("utf-8"))
> +                if found_bug_url:
> +                    bug_url_number -= 1

Ok, now I see what you wanted. So use something like this:
if found...:
    if bug_num.. == 1:
        print ...
    bug_num...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list