[Webkit-unassigned] [Bug 67935] webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67935





--- Comment #15 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-06-18 04:13:48 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=147839&action=review

> Tools/Scripts/webkitpy/common/checkout/changelog.py:350
> +        bug_url_regexp = 'https://bugs.webkit.org/show_bug.cgi\?id='

This url is already present in the config_urls which is imported at the top. Also what if someone uses a short url for the bug?

> Tools/Scripts/webkitpy/common/checkout/changelog.py:366
> +                    bug_url_number -= 1
> +                elif found_bug_url:
> +                    bug_url_number -= 1

If you always decrement the counter, then there is no need to put it in both cases. Simply put it after the 'if' block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.