[Webkit-unassigned] [Bug 73544] [EFL] Support for Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #57 from Kihong Kwon <kihong.kwon at samsung.com>  2012-06-17 23:34:04 PST ---
(From update of attachment 146824)
View in context: https://bugs.webkit.org/attachment.cgi?id=146824&action=review

>> Source/WebKit/PlatformEfl.cmake:79
>>  IF (ENABLE_NOTIFICATIONS)
> 
> I think you can add this to source list unconditionally because ewk_notification.cpp is already protected by #ifdef.

OK.

>> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:48
>> +            if (iter->first->tag() == notification->tag() && iter->first->url().protocol() == notification->url().protocol() && iter->first->url().host() == notification->url().host()) {
> 
> It looks it is better to use multiple lines for this conditions.

OK.

>> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:91
>> +    evas_object_smart_callback_call(m_view, "notification,permission,request", static_cast<void*>(const_cast<char*>(domain.utf8().data())));
> 
> I'm not sure whether multicasting is safe like this. EFL port has used (void*) C-type casting instead of C++ casting for this.
> 
> I think you can add internal functions to send signal to ewk_notificaiton.cpp

OK.

>> Source/WebKit/efl/ewk/ewk_notification.h:83
>> +EAPI const char *ewk_notification_title_get(Ewk_Notification *en);
> 
> As mentioned in comment #53, _get() needs to use *const*.

OK.

>> Tools/ChangeLog:9
>> +
> 
> Missing changed file in ChangeLog.

OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.