[Webkit-unassigned] [Bug 83865] [EFL] Add Web Inspector to WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83865





--- Comment #15 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-17 17:31:57 PST ---
(From update of attachment 145050)
View in context: https://bugs.webkit.org/attachment.cgi?id=145050&action=review

I think this patch is much better than before. Submit modified patch again.

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:84
> +    evas_object_smart_callback_call(m_inspectedView, "inspector,view,create", &inspectorView);

It looks m_inspectedView is webview. If so, you have to mention description of this signal to ewk_view.h

http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_view.h#L35

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:167
> +    evas_object_smart_callback_del(m_inspectorView, "inspector,view,destroy", notifyWebInspectorDestroy);

ditto.

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:225
> +    evas_object_smart_callback_call(m_inspectedView, "inspector,view,close", m_inspectorView);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.