[Webkit-unassigned] [Bug 89147] Web Inspector: Support 'Restart frame' in protocol and backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89147





--- Comment #14 from Peter Rybin <prybin at chromium.org>  2012-06-16 17:00:32 PST ---
(In reply to comment #10)
> (From update of attachment 147708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147708&action=review
> 
> > Source/WebCore/bindings/v8/DebuggerScript.js:261
> > +    function restart() {
> 
> Please move { to the next line.
Done

> > Source/WebCore/bindings/v8/ScriptFunctionCall.cpp:136
> > +        V8RecursionScope innerScope(getScriptExecutionContext());
> why did this change?

Rename variable that shadows another variable with the same name in this function.

> > Source/WebCore/inspector/JavaScriptCallFrame.idl:42
> > +        [Custom] InspectorObject restart();
> No need for Custom here.

Custom is kept, binding scripts otherwise won't let return V8 Value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.