[Webkit-unassigned] [Bug 89277] [Texmap] Share gaussian formula between shaders in TextureMapperShaderManager.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89277


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147958|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-06-16 07:03:14 PST ---
(From update of attachment 147958)
View in context: https://bugs.webkit.org/attachment.cgi?id=147958&action=review

> Source/WebCore/ChangeLog:8
> +        [Texmap] Share gaussian formula between shaders in TextureMapperShaderManager.
> +        https://bugs.webkit.org/show_bug.cgi?id=89277
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests. This patch doesn't change behavior.

You're doing a lot more than that, actually moving to a more accurate gaussian blur...
I like that, but please describe in the Changelog.

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:672
> +        }
> +        // Normalize the kernel

Extra line

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:678
> +    }
> +    return kernel;

Extra line

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.