[Webkit-unassigned] [Bug 89244] Web Inspector: Add progress events to the timeline to keep track of how much the main frame has loaded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 15 14:10:19 PDT 2012


--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-06-15 14:10:18 PST ---
(From update of attachment 147893)
View in context: https://bugs.webkit.org/attachment.cgi?id=147893&action=review

Looks good, but probably needs an inspector expert. Would also be nice to add PR (if any) and internal reviewer.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:212
> +

Better not change layout style for code we do not own. You might like this better but that is not a good enough reason.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:269
> +


> Source/WebCore/loader/ProgressTracker.cpp:221
> +    InspectorInstrumentation::updateProgress(frame.get(), m_progressValue*100);

Nit: better make it m_progressValue * 100 .

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list