[Webkit-unassigned] [Bug 89061] applyAuthorStyles makes rules declared in all enclosing shadow dom subtrees applicable.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89061


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147752|review?                     |review-
               Flag|                            |




--- Comment #9 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-06-15 10:16:45 PST ---
(From update of attachment 147752)
View in context: https://bugs.webkit.org/attachment.cgi?id=147752&action=review

getting really close now.

Thank you for the explanation!

> Source/WebCore/css/StyleResolver.cpp:952
> +    if (m_element->isInShadowTree() && !m_scopeStack.isEmpty()) {

Looks like early return would improve readability here.

> Source/WebCore/css/StyleResolver.h:534
> +        ScopeStackFrame() : m_scope(0), m_scopeGroup(0), m_ruleSet(0) { }

It's a scope index, right? Not scope group. What you're doing here is storing the actual index of the stack, creating a virtual sparse array.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.