[Webkit-unassigned] [Bug 89147] Web Inspector: Support 'Restart frame' in protocol and backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89147


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147708|review?                     |review-
               Flag|                            |




--- Comment #11 from Pavel Feldman <pfeldman at chromium.org>  2012-06-15 09:38:15 PST ---
(From update of attachment 147708)
View in context: https://bugs.webkit.org/attachment.cgi?id=147708&action=review

> Source/WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:49
> +v8::Handle<v8::Value> V8JavaScriptCallFrame::restartCallback(const v8::Arguments& args)

You don't need this.

> Source/WebCore/inspector/Inspector.json:2439
> +                "name": "restartFrame",

"hidden": true

> Source/WebCore/inspector/Inspector.json:2444
> +                    { "name": "callFrames", "type": "array", "optional": true, "items": { "$ref": "CallFrame"}, "description": "New stack trace." },

Should not be optional.

> Source/WebCore/inspector/Inspector.json:2445
> +                    { "name": "result", "type": "object", "optional": true, "description": "VM-specific description of the changes applied.", "hidden": true }

Should not be optional. Nuke the "changes applied part".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.