[Webkit-unassigned] [Bug 88482] [Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88482





--- Comment #39 from Shawn Singh <shawnsingh at chromium.org>  2012-06-14 18:57:47 PST ---
(From update of attachment 147685)
View in context: https://bugs.webkit.org/attachment.cgi?id=147685&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:242
> +static bool layerTargetSurfaceRequiresRedrawing(CCLayerImpl* layer)

I'm not sure about our past discussion, but looking at this version of the patch now, I would prefer to re-name this.

If this returns false, the name implies that the targetSurface does not require redrawing, which is not necessarily what we mean here.  I think what this function is doing is telling whether the layer needs to be redrawn to its targetSurface, no?

so shouldn't this be called "layerNeedsToRedrawOntoItsTargetSurface"   (or something similar but saying the exact same thing) ??

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.