[Webkit-unassigned] [Bug 89154] New: Use IntSize in RenderLayer to represent scroll offsets

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 18:49:02 PDT 2012


           Summary: Use IntSize in RenderLayer to represent scroll offsets
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jchaffraix at webkit.org
                CC: darin at apple.com, andersca at apple.com, sam at webkit.org

The code mixes IntPoint, IntSize and int, which makes it hard to read, let alone change.

The rest of WebCore assumes that an offset is an IntSize but ScrollableArea uses IntPoint / FloatPoint to represent offsets. I don't know if there is a consensus on offsets being points vs sizes but the usage seems to point at size.

This change aims at simplifying the logic by switching as much of RenderLayer to using IntSize for manipulating scroll offsets. This has the added benefit of simplifying some of the computations by doing both coordinates with one line of code.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list