[Webkit-unassigned] [Bug 89130] avoid min and max check in Color constructor when needed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 15:39:27 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89130


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-06-14 15:39:26 PST ---
Attachment 147662 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/Color.h:63:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:63:  The parameter name "g" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:64:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:64:  The parameter name "g" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:64:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:65:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:66:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:66:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:67:  The parameter name "g" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/Color.h:68:  The parameter name "g" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 10 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list