[Webkit-unassigned] [Bug 88344] Fix FastMalloc.cpp compile error for MSVC in 64-bit

Thu Jun 14 13:03:29 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=88344

WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com

--- Comment #27 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-06-14 13:03:29 PST ---
Attachment 147635 did not pass style-queue:

Source/WTF/wtf/FastMalloc.cpp:1117:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1119:  The parameter name "N" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WTF/wtf/FastMalloc.cpp:1122:  The parameter name "N" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WTF/wtf/FastMalloc.cpp:1125:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1131:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1131:  tc_length is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1159:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Source/WTF/wtf/FastMalloc.cpp:1163:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1164:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1165:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Source/WTF/wtf/FastMalloc.cpp:1176:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WTF/wtf/FastMalloc.cpp:1198:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1199:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1203:  locked_size_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1207:  lock_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1210:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1210:  Extra space between size_t and size_class_  [whitespace/declaration] [3]
Source/WTF/wtf/FastMalloc.cpp:1210:  size_class_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1211:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1211:  Extra space between Span and empty_  [whitespace/declaration] [3]
Source/WTF/wtf/FastMalloc.cpp:1211:  empty_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1212:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1212:  Extra space between Span and nonempty_  [whitespace/declaration] [3]
Source/WTF/wtf/FastMalloc.cpp:1212:  nonempty_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1213:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1213:  Extra space between size_t and counter_  [whitespace/declaration] [3]
Source/WTF/wtf/FastMalloc.cpp:1213:  counter_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1215:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1218:  tc_slots_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1220:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1222:  used_slots_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1223:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1226:  cache_size_Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Fa..." exit_code: 1
 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1260:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WTF/wtf/FastMalloc.cpp:1291:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1293:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1293:  kernel_supports_tls is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WTF/wtf/FastMalloc.cpp:1294:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1297:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1298:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1302:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1303:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:1305:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1305:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WTF/wtf/FastMalloc.cpp:1308:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WTF/wtf/FastMalloc.cpp:1310:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1312:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WTF/wtf/FastMalloc.cpp:1313:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WTF/wtf/FastMalloc.cpp:1314:  One space before end of line comments  [whitespace/comments] [5]
Source/WTF/wtf/FastMalloc.cpp:1320:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 50 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.