[Webkit-unassigned] [Bug 89103] Should be easier to write cross-platform accessibility layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 11:46:24 PDT 2012


--- Comment #3 from chris fleizach <cfleizach at apple.com>  2012-06-14 11:46:24 PST ---
(In reply to comment #2)
> Moving Dominic's comments from that bug here:
> > > BTW, I would really like to see a way to write "cross-platform" accessibility tests that test for the WebCore role rather than the platform-specific role, I just haven't had a chance to think about how to do that refactoring yet.
> >
> > I've only taken a very quick look at the code, but it seems like it should be possible to set up a mechanism to test the "real" role in DumpRenderTree by adding some methods to AccessibilityUIElement. Maybe with an enum hanging around that's mapped onto ARIARoleMap?
> >
> > Seomthing like AccessibilityUIElement::isRole([enum]) and AccessibilityUIElement::isRoleDescription([enum])?
> >
> > Is there a bug for this sort of refactoring? It sounds like it'd be useful...
> Added a new bug:
> https://bugs.webkit.org/show_bug.cgi?id=89103
> isRole wouldn't work very well, we'd have to expose the enum to JavaScript. Instead we should just expose the WebCore role name as a string in JavaScript, and make it a compile error to add a new role without adding the role name.
> I don't think we need to have role descriptions in cross-platform tests, that's a Mac-only concept. The WebCore role enum should encompass all distinct roles, and each platform should map a role to whatever makes sense on that platform - on Mac one role might map to a {role, roleDescription} tuple.

I think we should have DRT specific method that can get the roleValue() from AccessibilityObject and then convert that into a neutral string that we can test against in the layout tests

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list