[Webkit-unassigned] [Bug 67935] webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67935


Peter Gal <galpeter at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |galpeter at inf.u-szeged.hu




--- Comment #13 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-06-14 10:53:52 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=147564&action=review

> Tools/Scripts/webkitpy/common/checkout/changelog.py:348
> +        latest_entry = self.latest_entry()._contents

Didn't you wanted to use the .contents() method instead of the _contents? It is marked as non-public, we should honor the conventions.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:349
> +        found_reviewer = re.search(".*NOBODY\s*\(OOPS!\).*", latest_entry, re.MULTILINE)

hmm.. do we really need the '.*' parts? It should work without those.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:357
> +            latest_entry = True

Do you really wanted to name this the same as above? Maybe this should be renamed to describe its purpose better.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:364
> +                    print "\n        Reviewed by " + reviewer.encode("utf-8") + "."

I think it'll be better to use the % operator to format strings (or .format)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.