[Webkit-unassigned] [Bug 75825] webkit-patch land should automatically add svn:mime-type for .png files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75825


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147528|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #27 from Dirk Pranke <dpranke at chromium.org>  2012-06-14 10:35:41 PST ---
(From update of attachment 147528)
View in context: https://bugs.webkit.org/attachment.cgi?id=147528&action=review

assuming my comments are correct, fix the comments and variable names and this should be fine.

> Tools/Scripts/webkitpy/common/checksvnconfigfile.py:36
> +    was the file read successful, is there enable the auto-props, is there enable the svn:mime-type for png

I'm not sure if this is a bug or if this is just written wrong, but it looks like you want to return True if something failed, right? So I would rewrite this as "is this file missing, is auto-props missing, is the svn:mime-type for png missing"

> Tools/Scripts/webkitpy/style/checkers/png.py:58
> +            (file_read, autoprop, png) = checksvnconfigfile.check(self, self._host, self._fs)

I would rename these variables the same way I renamed the docstring, so file_missing, autoprop_missing, png_missing

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.