[Webkit-unassigned] [Bug 88838] Delete Grammar markers on editing

Thu Jun 14 02:05:15 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=88838

Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147272|0                           |1
        is obsolete|                            |
 Attachment #147523|                            |review?
               Flag|                            |

--- Comment #10 from Hironori Bono <hbono at chromium.org>  2012-06-14 02:05:10 PST ---
Created an attachment (id=147523)
 --> (https://bugs.webkit.org/attachment.cgi?id=147523&action=review)
Patch v2 (applied comments and updated description)

Greetings Niwa-san,

Thanks for your review and comments. While reading your comments, I notice I just like to allow the WebKit layer to decide whether to delete markers in Editor::updateMarkersForWordsAffectedByEditing(). (I got confused while integrating grammar checkers to EditorClientImpl::checkGrammarOfString().) Even though I have applied all of your comments, it would be definitely helpful to shoot me if this change still has problems.

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.