[Webkit-unassigned] [Bug 88950] [Blackberry] add a new Api named setAllowNotification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88950





--- Comment #14 from Chris.Guan <chris.guan at torchmobile.com.cn>  2012-06-13 19:57:46 PST ---
(In reply to comment #12)
> (From update of attachment 147468 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147468&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:6358
> > +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> > +void WebPage::setAllowNotification(const WebString& domain, bool allow)
> > +{
> > +    static_cast<NotificationPresenterImpl*>(NotificationPresenterImpl::instance())->onPermission(domain.utf8(), allow);
> > +}
> > +#endif
> 
> I am not sure I like the whole method being wrapped by #if. If you disable it, how will the client side build? the #if macro is not visible outside webkit.
> 
> > Source/WebKit/blackberry/Api/WebPage.h:270
> >  
> > +    void setAllowNotification(const WebString& domain, bool allow);
> > +
> 
> you did not wrap the method in the header.
we can not wrap this method in header file, because libwebview build fails because it does not know the macro of "ENABLE".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.