[Webkit-unassigned] [Bug 88936] StringImpl::characters can return NULL for an empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88936


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147440|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #15 from Darin Adler <darin at apple.com>  2012-06-13 18:34:29 PST ---
(From update of attachment 147440)
View in context: https://bugs.webkit.org/attachment.cgi?id=147440&action=review

> Source/WTF/wtf/unicode/icu/CollatorICU.cpp:99
> +    static UChar dummy;

No need to make this static. A pointer to the stack is just as good as a pointer to a global variable.

> Source/WTF/wtf/unicode/icu/CollatorICU.cpp:100
> +    if (!lhs && !lhsLength)

We don’t need to check both of these. Doesn’t matter which we check, but I don’t want an extra branch to check both. My preference would be to only check the length.

> Source/WTF/wtf/unicode/icu/CollatorICU.cpp:101
> +      lhs = &dummy;

WebKit project indents 4 spaces, not 2.

> Source/WTF/wtf/unicode/icu/CollatorICU.cpp:103
> +    if (!rhs && !rhsLength)
> +      rhs = &dummy;

Same comments again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.