[Webkit-unassigned] [Bug 87973] [GTK] Implement disableImageLoading in DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87973


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147428|review?                     |review-
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-06-13 18:16:20 PST ---
(From update of attachment 147428)
View in context: https://bugs.webkit.org/attachment.cgi?id=147428&action=review

Seems sane though there are a few things that look off:

> Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:453
>      // FIXME: Implement for testing fix for https://bugs.webkit.org/show_bug.cgi?id=27896
>      // Also need to make sure image loading is re-enabled for each new test.

It'd make sense to remove this comment now.

> LayoutTests/ChangeLog:6
> +        [GTK] Implement disableImageLoading in DRT
> +        Add TEXT expectation to favicon-loads-with-icon-loading-override.html
> +        which was only working by accident.
> +        https://bugs.webkit.org/show_bug.cgi?id=87973

Your changelog looks a little funky here. The description should go below the "Reviewed by" line.

> LayoutTests/platform/gtk/TestExpectations:1293
> +BUGWKGTK   : http/tests/misc/favicon-loads-with-icon-loading-override.html = TEXT

It seems you are replacing an existing failure with another?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.