[Webkit-unassigned] [Bug 88936] StringImpl::characters can return NULL for an empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88936


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147410|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-13 14:33:54 PST ---
(From update of attachment 147410)
View in context: https://bugs.webkit.org/attachment.cgi?id=147410&action=review

> Source/WTF/wtf/unicode/icu/CollatorICU.cpp:106
> +    if (!lhs && !lhsLength)
> +      lhs = (const UChar*)1;
> +    if (!rhs && !rhsLength)
> +      rhs = (const UChar*)1;

Please use "" here instead.  I don't see any value in using a made up pointer value like 1.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.