[Webkit-unassigned] [Bug 88931] some headers are included twice in WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 12:45:25 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88931


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147179|review?                     |review-
               Flag|                            |




--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2012-06-13 12:45:24 PST ---
(From update of attachment 147179)
View in context: https://bugs.webkit.org/attachment.cgi?id=147179&action=review

Looks good, but you should try to remove the one so not to make the sorting worse. Also r- based on Adam's comment.

> Source/WebCore/rendering/InlineFlowBox.cpp:-39
> -#include "RootInlineBox.h"

I think you should remove the first occurrence of it, otherwise you violate (or keep violating) the alphabetic sorting rule.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list