[Webkit-unassigned] [Bug 88451] Extra HandleScope in V8Proxy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 11:09:37 PDT 2012


--- Comment #19 from Eriq Augustine <eaugusti at chromium.org>  2012-06-13 11:09:19 PST ---
(In reply to comment #18)
> (From update of attachment 146372 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146372&action=review
> > Source/WebCore/bindings/v8/V8Proxy.cpp:263
> > +        if (evaluationResult.IsEmpty())
> > +            evaluationResult = v8::Local<v8::Value>::New(v8::Undefined());
> Does this line make sense?  I thought empty handles and v8::Undefined where the same...

I don't think they act the same (at least in the context of v8:Arrays). I looked at how v8:Array Sets and it just dereferences the handle which asserts if the handle is empty

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list