[Webkit-unassigned] [Bug 88837] [Chromium] Add WebDocument.images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88837





--- Comment #5 from Jesse Greenwald <jgreenwald at chromium.org>  2012-06-13 10:57:40 PST ---
(From update of attachment 147184)
I'll expand on the ChangeLog when I upload the next patch.  Thanks for taking a look!


View in context: https://bugs.webkit.org/attachment.cgi?id=147184&action=review

>> Source/WebKit/chromium/src/WebDocument.cpp:142
>> +void WebDocument::images(WebVector<WebElement>& results) const
> 
> Why "const"?  You're ending up const_casting the Document anyway.  It seems better to model this after body() and head() and skip the const.

I originally modeled this after forms(), which is const.  Actually, isn't body() const as well?  Either way, I can remove const from this method.

>> Source/WebKit/chromium/src/WebDocument.cpp:150
>> +        // Strange but true, sometimes node can be 0.
> 
> I'd skip this comment.  WebKit usually only includes comments if they something about why the code is the way it is.

Ok.  For reference, the comment was copied from forms().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.