[Webkit-unassigned] [Bug 88580] RenderObject should not know about first-line element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 10:37:02 PDT 2012


--- Comment #5 from Levi Weintraub <leviw at chromium.org>  2012-06-13 10:37:01 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > For the boolean, this is unfortunately the current state of our code where we get a boolean telling us if we are on the first line. I would have preferred more differentiated code paths but that's likely too difficult to implement as part of this change.
> > 
> > The naming could indeed love some massaging. It's more a firstLineAwareStyle() than really a styleForFirstLine().
> I like that!

Seconded! I wasn't saying we can't take a boolean, I was just saying that the name styleForFirstLine didn't actually seem to describe what the function did. firstLineAwareStyle is clearer.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list