[Webkit-unassigned] [Bug 87790] WTF TCSpinLock.h doesn't compile for x64 with Visual Studio

Wed Jun 13 09:15:15 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=87790

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145821|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #5 from Brent Fulgham <bfulgham at webkit.org>  2012-06-13 09:15:15 PST ---
(From update of attachment 145821)
View in context: https://bugs.webkit.org/attachment.cgi?id=145821&action=review

Thanks for looking into this!  I have a couple of minor requests, otherwise this looks great.

> Source/WTF/ChangeLog:8
> +        * wtf/TCSpinLock.h:

Please state here that you modified the test for MSVC suitability.

> Source/WTF/wtf/TCSpinLock.h:-37
> -#if (CPU(X86) || CPU(X86_64) || CPU(PPC)) && (COMPILER(GCC) || COMPILER(MSVC))

I don't care for the reformatting of these tests, since it loses the distinction between architecture and compiler.

I would prefer to see something along the lines of:
#if ((CPU(X86) || CPU(X86_64) || CPU(PPC)) && COMPILER(GCC)) || (CPU(X86) && COMPILER(MSVC))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.