[Webkit-unassigned] [Bug 77013] [BlackBerry] Implement OSAllocator::commit/decommit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77013





--- Comment #15 from Yong Li <yoli at rim.com>  2012-06-13 09:05:35 PST ---
(In reply to comment #14)
> Hey there,
> 
> the patchset you link to above does not cover the use case in TCSystemAlloc.cpp:
> 
> /home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/TCSystemAlloc.cpp: In function 'void TCMalloc_SystemRelease(void*, std::size_t)':
> /home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/TCSystemAlloc.cpp:390: error: 'MADV_FREE_REUSABLE' was not declared in this scope
> /home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/TCSystemAlloc.cpp:390: error: 'madvise' was not declared in this scope
> /home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/TCSystemAlloc.cpp: In function 'void TCMalloc_SystemCommit(void*, std::size_t)':
> /home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/TCSystemAlloc.cpp:486: error: 'MADV_FREE_REUSE' was not declared in this scope
> /home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/TCSystemAlloc.cpp:486: error: 'madvise' was not declared in this scope
> 
> Did you miss that, or is something going wrong on my side?

We don't use TCSystemAlloc.

So 2 options I can see here:

1. turn off HAVE_MADV_FREE and HAVE_MADV_FREE_REUSE. However the memory allocator won't be able to decommit free pages (return RAM to system).
2. Add an implementation as I did in r111234 for TCSystemAlloc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.