[Webkit-unassigned] [Bug 88950] [Blackberry] add a new Api named setAllowNotification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 07:46:14 PDT 2012


--- Comment #3 from Antonio Gomes <tonikitoo at webkit.org>  2012-06-13 07:46:13 PST ---
(From update of attachment 147257)
View in context: https://bugs.webkit.org/attachment.cgi?id=147257&action=review

It looks good. I wonder if it fits better to WebSettings instead of WebPage. What you you think?

> Source/WebKit/blackberry/Api/WebPage.cpp:6346
> +void WebPage::setAllowNotification(const WebString& domain, bool allow)

I think you need UNUSED_PARAM for 'domain' and 'allow' in an #else block

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list