[Webkit-unassigned] [Bug 88838] Delete Grammar markers on editing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 03:16:37 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88838


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147046|0                           |1
        is obsolete|                            |
 Attachment #147105|0                           |1
        is obsolete|                            |
 Attachment #147116|0                           |1
        is obsolete|                            |
 Attachment #147272|                            |review?
               Flag|                            |




--- Comment #8 from Hironori Bono <hbono at chromium.org>  2012-06-13 03:16:36 PST ---
Created an attachment (id=147272)
 --> (https://bugs.webkit.org/attachment.cgi?id=147272&action=review)
Patch v1

Greetings,

While investigating layout-test errors, I notice it may be better to call TextCheckClient::shouldEraseMarkersAfterChangeSelection() in Editor::updateMarkersForWordsAffectedByEditing() instead of setting WTF_USE_MARKER_REMOVAL_UPON_EDITING to 1. (We need to delete markers on editing only when this function returns false. If this function returns true, WebKit removes markers when we start editing grammatically-incorrect words.)

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list