[Webkit-unassigned] [Bug 88663] Renamed DeviceOrientation to DeviceOrientationData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88663


Hans Wennborg <hans at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dino at apple.com




--- Comment #21 from Hans Wennborg <hans at chromium.org>  2012-06-13 02:12:47 PST ---
The reason for the patch is to match the DeviceMotion implementation. DeviceOrientation and DeviceMotion are part of the same spec, and work in very similar ways.

Since the DeviceMotion bits were implemented at a later time, the two implementations are slightly different.

We think the code would be made more clear by making the two implementations more consistent.

In the choice between the two names DeviceOrientation and DeviceOrientationData, we think the latter is more self-explanatory. The name DeviceOrientation could just as well be the name of an interface for interacting with the DeviceOrientation API. DeviceOrientationData on the other hand, makes it clear (at least to me) that it's a class holding the raw data.


Hopefully this makes the motivation clear. It would be great if someone would like to review this.

The DeviceMotionData class was added in Bug 42865. Dean, maybe you could comment on the naming?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.