[Webkit-unassigned] [Bug 88756] [WK2][EFL][WTR] TestNetscapePlugin is required.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88756





--- Comment #2 from Ryuan Choi <ryuan.choi at samsung.com>  2012-06-12 16:08:32 PST ---
(From update of attachment 147031)
View in context: https://bugs.webkit.org/attachment.cgi?id=147031&action=review

> Tools/CMakeLists.txt:6
> +    ADD_SUBDIRECTORY(DumpRenderTree/TestNetscapePlugIn)

You commented that this is required for WTR/EFL, but it is in DRT/.
Isn't it required DRT also?

I want to know whether this make the results of DRT better.

> Tools/ChangeLog:4
> +        Added cmake script for TestNetscapePlugin
> +        https://bugs.webkit.org/show_bug.cgi?id=88756

Bug title is different.

> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:8
> +    ${WEBKIT_TESTNETSCAPEPLUGIN_DIR}/main.cpp
> +    ${WEBKIT_TESTNETSCAPEPLUGIN_DIR}/Tests/DocumentOpenInDestroyStream.cpp

We commonly give an empty line when folder is changed in sour lists.

> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:35
> +ADD_LIBRARY(TestNetscapePlugin SHARED ${WebKitTestNetscapePlugin_SOURCES})
> +

Empty line is not necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.