[Webkit-unassigned] [Bug 88344] Fix FastMalloc.cpp compile error for MSVC in 64-bit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 14:42:34 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88344





--- Comment #13 from Alex Christensen <alex.christensen at flexsim.com>  2012-06-12 14:42:33 PST ---
scratch that.  I got it working with specialized templates and am uploading a new patch.

(In reply to comment #12)
> Using template specialization would change a lot of the pointer types, especially when OS(DARWIN) is true.  This would require a bit more surgery on this cpp file.  Would it be worth restructuring the whole file just to save 6k of memory in a global variable with one instance?
> 
> (In reply to comment #10)
> > (In reply to comment #8)
> > > The preprocessor cannot use the sizeof operator.  Since this would add a maximum of 64 bytes per TCMalloc_Central_FreeListPadded and there is only an array of kNumClasses of these objects, and kNumClasses is 68, this would use a maximum of 4420 bytes.  I don't think this is anything to worry about.
> > 
> > Oops, you're right. However, we can use template specialization based on sizeof.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list