[Webkit-unassigned] [Bug 73634] [GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73634


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #146829|review?                     |review+
               Flag|                            |




--- Comment #22 from Martin Robinson <mrobinson at webkit.org>  2012-06-12 12:52:59 PST ---
(From update of attachment 146829)
View in context: https://bugs.webkit.org/attachment.cgi?id=146829&action=review

Okay. This is a good start. Now we just need to unify the GL and ImageBuffer implementations.

> Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp:99
> +        // OpenGL keeps the pixels stored bottom up, so we need to flip the image here.
> +        context->translate(0, height);
> +        context->scale(FloatSize(1, -1));

I think you want to translate and scale before applying the compositing matrix, but I'm not certain.

> Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.h:43
> +    void paintToCanvasRect(const unsigned char* imagePixels, int imageWidth, int imageHeight, const FloatRect& canvasRect, PlatformContextCairo*);

I guess this was added accidentally? I don't see the implementation anywhere.

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:544
> +

This newline seems to be added accidentally as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.