[Webkit-unassigned] [Bug 88807] Input elements with type=range do not have default touch handlers.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 11:22:30 PDT 2012


--- Comment #5 from Robert Kroeger <rjkroege at chromium.org>  2012-06-12 11:22:29 PST ---
(From update of attachment 146912)
View in context: https://bugs.webkit.org/attachment.cgi?id=146912&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests. (OOPS!)
> You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]

You need to update this or it will get bounced from the commit queue.

Also, a longer more detailed ChangeLog is necessary.

> Source/WebCore/dom/Touch.cpp:76
> +{

you will need to test your slider inside a transform. Like rotated.

> Source/WebCore/dom/Touch.h:69
> +    RefPtr<Frame> m_frame;

this seems wrong to me. How do other events deal with this?

> Source/WebCore/dom/TouchEvent.h:72
> +    virtual bool isTouchEvent() const OVERRIDE;

afaik WebCore doesn't use the OVERRIDE macro

> Source/WebCore/html/RangeInputType.cpp:37
> +#include "Frame.h"

i expect that you should avoid this.

> Source/WebCore/html/RangeInputType.cpp:155
> +        event->preventDefault();

you are the default handler? do you need to call this?

> Source/WebCore/html/RangeInputType.h:54
> +    virtual void handleTouchEvent(TouchEvent*) OVERRIDE;

ok... maybe I was wrong about the OVERRIDE. :-)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list