[Webkit-unassigned] [Bug 88885] New: [Chromium] WebFrameImpl::find doesn't work for searching from a selection.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 10:17:36 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88885

           Summary: [Chromium] WebFrameImpl::find doesn't work for
                    searching from a selection.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mkosiba at chromium.org


This is related to http://code.google.com/p/chromium/issues/detail?id=129552.

When a user is doing a FindInPage search it comes in as a series of WebFrameImpl::find calls (find("f"), find("fo"), find("foo")). All of the calls have the findNext option set to false. If the user additionally selected text before typing in the search term all of the find calls need to start searching at the same point.
In other words a find call with !options.findNext doesn't necessarily mean that this is a new search, it could also be a refinement.

The current implementation loses state (m_activeMatch is set to 0) if !options.findNext. What we really want is to preserve the active find match until the user stops interacting with the find widget.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list