[Webkit-unassigned] [Bug 88866] ASSERT_NOT_REACHED in StylePropertySet::fontValue when accessing font style property through JS after setting style font size.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 08:45:12 PDT 2012


Alexander Pavlov (apavlov) <apavlov at chromium.org> changed:

           What    |Removed                     |Added
                 CC|                            |alexis.menard at openbossa.org
                   |                            |, koivisto at iki.fi

--- Comment #1 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-06-12 08:45:11 PST ---
OK, some pre-history. Originally, the "font" property was a first-class CSS property, not a shorthand (which broke a few things across WebKit, including the Web Inspector). I fixed this to the extent of relying on the valid longhand property values found in the style. Originally the asserting code was seemingly found in the CSSComputedStyleDeclaration class but was since then moved into StylePropertySet by koivisto at iki.fi (:anttik). He knows best how things work in the CSS land, since he's its primary maintainer, and is in the process of refactoring the entire thing.

Antti, can you advise on possible behavior impact introduced by moving the asserting code (String StylePropertySet::fontValue() const) from CSSStyleDeclaration into StylePropertySet? It relied on "inital" font longhand values being always present in the computed style, but no longer seems to be the case...

Alexis, I've added you just in case you may know something about the underlying matter, since you changed the CSSParser font parsing code around 2 months ago (http://trac.webkit.org/changeset/114895).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list