[Webkit-unassigned] [Bug 88321] [Qt][Win] Fix broken QtWebKit5.lib linking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88321





--- Comment #22 from Andras Becsi <abecsi at webkit.org>  2012-06-12 06:18:07 PST ---
(In reply to comment #21)
> (In reply to comment #20)
> > Isn't the basic issue that for _each_ sublibrary we do
> > 
> > DEFINES += BUILDING_WEBKIT
> > 
> > in Tools/qmake/mkspecs/features/default_post.prf, whereas BUILDING_WEBKIT should only be defined in the final linking phase of the dll?
> > 
> > At least I remember having similar issues with the old build system which were caused by the wrongly defined BUILDING_WEBKIT.
> 
> 
> BUILDING_WEBKIT controls the exports for the final QtWebKit library (QWEBKIT_EXPORT), which we have spread out in multiple static libs,  and we might use between static libs. So defining BUILDING_WEBKIT for all the static libs is correct AFAICT, so that they are all dllexport.

But in Source/WebKit/qt/Api/qwebkitglobal.h the "if defined(BUILDING_WEBKIT)" check is guarded by QT_MAKEDLL which is not defined when building a static lib, so we seem to always end up with "define QWEBKIT_EXPORT Q_DECL_IMPORT" when building the static libraries.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.