[Webkit-unassigned] [Bug 88321] [Qt][Win] Fix broken QtWebKit5.lib linking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88321





--- Comment #19 from Csaba Osztrogonac <ossy at webkit.org>  2012-06-12 04:24:15 PST ---
(In reply to comment #18)
> (In reply to comment #16)
> > (In reply to comment #15)
> > > (In reply to comment #14)
> > > > ImageQt.obj problem is come from this change - http://trac.webkit.org/changeset/119924/trunk/Source/WebCore/platform/graphics/qt/ImageQt.cpp
> > > > 
> > > > Is this function exported to QtXXXX.dll?
> > > 
> > > My recollection is that it wasn't exported (looked like a private API), so I copied the code into webkit instead. Might be better to change qtbase to export it, though? I'm not sure what the rationale was for removing the functionality in the first place, it's useful to Windows developers...
> > 
> > It should be exported.
> > qtbase/src/gui/image/qpixmap_win.cpp:
> > Q_GUI_EXPORT QPixmap qt_pixmapFromWinHBITMAP(HBITMAP bitmap, int hbitmapFormat = 0)
> > 
> > and it is used is several places (printsupport and platform plugin) in the same way as I did. Btw, I don't understand how the hell the Q_GUI_EXPORT declaration turned into __dllspec(dllimport)??? However, if we can't do better than let's copy the code.
> 
> It is normal Q_GUI_EXPORT is __declspec(dllexport) when you build 
> the lib and it is __declspec(dllimport) if you use the lib.
> 
> #  define Q_DECL_EXPORT __declspec(dllexport)
> #  define Q_DECL_IMPORT __declspec(dllimport) 
> 
> ...
> 
> #    if defined(QT_BUILD_GUI_LIB)
> #      define Q_GUI_EXPORT Q_DECL_EXPORT
> #    else
> #      define Q_GUI_EXPORT Q_DECL_IMPORT
> #    endif

I checked QtQui5.dll with "dumpbin /exports" and it said this symbol is exported:
4565 11D4 0005AE30 ?qt_pixmapFromWinHBITMAP@@YA?AVQPixmap@@PAUHBITMAP__@@H at Z

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.