[Webkit-unassigned] [Bug 88806] [Chromium-Android] Remove Android-specific code in FontPlatformDataHarfBuzz.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 11 16:07:16 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88806





--- Comment #2 from Xianzhu Wang <wangxianzhu at chromium.org>  2012-06-11 16:07:15 PST ---
(In reply to comment #1)
> Since getAdvancedTypefaceMetrics() is only called to get the em size in font units (the caller disregards all other returned information), I don't think this would be the right approach. See the following bugs for more context (also referred to by a TODO in the code):
> 
> Bug 75702 ([Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type metrics for Android in FontPlatformData)
> Bug 75961 ([Chromium] Switch to using the new SkTypeface::GetUnitsPerEm API)
> 
> http://code.google.com/p/skia/issues/detail?id=441 (Add SkTypeface::GetUnitsPerEm())
> 
> +reed

Yes, I saw those bugs, but this one just removes the Android-specific code with the bugs (to switch to SkTypeface::GetUnitsPerEm()) still open. That is, it combines two different 'incorrect' ways into one :)

Found this by the way when cleaning up Android-specific code in the file in downstream. I'm OK to delay this until we fix 75961.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list